Skip to content

Use Docsy-friendly section partial #51969

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Use Docsy-friendly section partial #51969

wants to merge 1 commit into from
+84 −70

Conversation

@lmktfy
Copy link
Member

@lmktfy lmktfy commented Aug 19, 2025 •
edited
Loading

Use a partial for <section> that will work with near-vanilla Docsy.

Helps with issue #41171.

Preview of the updated page.

@k8s-ci-robot k8s-ci-robot added the area/web-development Issues or PRs related to the kubernetes.io's infrastructure, design, or build processes label Aug 19, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign divya-mohan0209 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 19, 2025
@lmktfy
Copy link
Member Author

lmktfy commented Aug 19, 2025

There are two kinds of CSS change.

  1. Fixes for the video section to make it display about right after the update.
  2. Hiding the KubeWeekly sign up link (see Update site landing page #51829)

@netlify
Copy link

netlify bot commented Aug 19, 2025 •
edited
Loading

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit e4f5c1b
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-io-main-staging/deploys/6904eb21cd796800084b6fd7
😎 Deploy Preview https://deploy-preview-51969--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@lmktfy
Copy link
Member Author

lmktfy commented Aug 21, 2025

Oh, hmm. It worked on my machine when I previewed it.

/retitle [WIP] Use Docsy-friendly section partial

@k8s-ci-robot k8s-ci-robot changed the title Use Docsy-friendly section partial [WIP] Use Docsy-friendly section partial Aug 21, 2025
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 21, 2025
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 2, 2025
@lmktfy lmktfy force-pushed the 20250819_tweak_section_partial branch from 4a8cd65 to ae7fa1b Compare September 7, 2025 14:39
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 7, 2025
@lmktfy
Copy link
Member Author

lmktfy commented Sep 7, 2025 •
edited
Loading

/retitle Use Docsy-friendly section partial

@dipesh-rawat @natalisucks this is ready for a review (I hope - it works on my machine)

@k8s-ci-robot k8s-ci-robot changed the title [WIP] Use Docsy-friendly section partial Use Docsy-friendly section partial Sep 7, 2025
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 7, 2025
@lmktfy lmktfy force-pushed the 20250819_tweak_section_partial branch from ae7fa1b to 6260948 Compare September 7, 2025 20:54
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 7, 2025
@lmktfy lmktfy force-pushed the 20250819_tweak_section_partial branch from 6260948 to 38f6e4c Compare September 13, 2025 14:35
@lmktfy lmktfy force-pushed the 20250819_tweak_section_partial branch from 38f6e4c to fc0f9c7 Compare October 6, 2025 17:36
dipesh-rawat
dipesh-rawat reviewed Oct 6, 2025
View reviewed changes
assets/scss/_base.scss

// KubeWeekly
#kubeweekly {
visibility: hidden;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change leaves some extra empty space on the homepage where the kubeweekly form used to be. Just checking if this is intentional? If so, maybe we could remove the kubeweekly shortcode from homepage to tidy up the spacing.

website/content/en/_index.html

Line 67 in 7866af8

{{< kubeweekly id="kubeweekly" >}}

home

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is intentional. I didn't want to make lots of change in this one PR.

@lmktfy lmktfy force-pushed the 20250819_tweak_section_partial branch 2 times, most recently from a7c9add to 168703f Compare October 30, 2025 21:54
@lmktfy
Copy link
Member Author

lmktfy commented Oct 30, 2025

Actually, #51829 drops KubeWeekly.

dipesh-rawat
dipesh-rawat reviewed Oct 31, 2025
View reviewed changes
assets/scss/_custom.scss
color: #ffffff !important;
}

body.td-home section#upcoming-events > .col > .row {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The upcoming events section in the preview (here) looks slightly off. The background doesn’t appear to span the full width. Is this an intentional design update, or is it a regression?

preview-homepage

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works on my machine, unfortunately. I have tried to make a fix.

What browser / setup can I use to reproduce the symptom?

@lmktfy
Use Docsy-friendly section partial
e4f5c1b 
Use a partial for <section> that will work with near-vanilla Docsy.
@lmktfy lmktfy force-pushed the 20250819_tweak_section_partial branch from 168703f to e4f5c1b Compare October 31, 2025 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@natalisucks natalisucks Awaiting requested review from natalisucks

1 more reviewer

@dipesh-rawat dipesh-rawat dipesh-rawat left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area/web-development Issues or PRs related to the kubernetes.io's infrastructure, design, or build processes cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lmktfy @k8s-ci-robot @dipesh-rawat